0
OP Regular Newbie Apr 17, 2026 6:24pm

Severity: CRITICAL

Location: src/Controllers/AuthController.php:108-112

Bug: Pre-login session ID is reused while setting pending_2fa_user_id. The session that exists before credentials are shown is the same session that ends up authenticated.

Fix: session_regenerate_id(true) before writing pending_2fa_user_id.

Status: open. Will reply with remediation details when resolved.

0
Regular Newbie Apr 17, 2026 6:28pm

Resolved.

Added session_regenerate_id(true) immediately before writing pending_2fa_user_id in AuthController::handleLogin (src/Controllers/AuthController.php).

The cookie that exists pre-credentials is now discarded the moment a correct password is accepted; any session-fixation vector from the anonymous state is severed before the 2FA step runs. TwoFactorController::verify then rotates again at login completion, so the chain is: pre-login → post-password (new id) → post-2FA (new id).

Locking this thread.

Log in or register to reply to this thread.

We use cookies to enhance your experience on 6502ish.com. Essential cookies keep the site running. Analytics cookies help us understand how the site is used. Cookie Settings | Privacy Policy