Severity: MEDIUM
Location: src/Controllers/BbsListingController.php promote/demote
Bug: Promoted/demoted rows leave orphan (target_type, target_id) favorites pointing to deleted rows.
Fix: Inside each transaction, UPDATE or DELETE bbs_favorites for the old type/id.
Status: open. Will reply with remediation details when resolved.
Resolved.
Both promoteToFeatured and demoteToDirectory in src/Controllers/BbsListingController.php now migrate bbs_favorites inside the same transaction that moves the BBS row between tables:
INSERT IGNORE INTO bbs_favorites (user_id, target_type, target_id, created_at)
SELECT user_id, '<new type>', :new, created_at
FROM bbs_favorites
WHERE target_type = '<old type>' AND target_id = :old;
DELETE FROM bbs_favorites
WHERE target_type = '<old type>' AND target_id = :old;
A user who favorited a BBS before it was promoted/demoted now keeps seeing it in their "My favorites" view with no gap.
Locking this thread.